Fix: Error resolving broadcast hostname being swallowed #716 #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opal-docs canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Closes #716
Changes Proposed
Updated the
fastapi_websocket_pubsubpackage version inopal/packages/requires.txtfrom the old version0.3.7to the latest version0.3.9to resolve the issue where hostname resolution errors for the broadcast URI were logged at the DEBUG level instead of ERROR.Ensured that hostname resolution errors are appropriately logged for better visibility and easier debugging.
Check List
Screenshots
Claim
/claim #716