Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor 2 #15

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Refactor 2 #15

wants to merge 17 commits into from

Conversation

patinthehat
Copy link
Member

This PR refactors the integrations functionality:

  • reorganize dotenv vault integration
  • add infisical integration
  • add generic integration interface and run all integrations on workflow init

@what-the-diff
Copy link

what-the-diff bot commented Sep 15, 2023

PR Summary

  • Introduction of Infisical Integration

    • The README.md and workflow.go files were updated to incorporate a new feature that integrates with Infisical workspace. This new feature permits us to load secrets from the Infisical workspace. An example of how we can load secrets has been included in the README.md file for more clarity.
  • Updated Checksum Generation

    • The update-checksums task in the Taskfile.dist.yaml file now generates checksums for YAML files in a specific directory, which improves our file verification process. It also removes the prefix from the checksum file, thereby resulting in cleaner file paths.
  • Addition of dotenv-vault Integration

    • Two new files (dotenv_vault.go and client.go) have been introduced which implement a dotenv-vault integration. This allows for loading secrets from a .env.vault file, serving as a secure way to handle sensitive data.
  • Introduction of Infisical Integration Tests

    • Two additional files (client.go and infiscal_test.go) have been added that implement tests for the Infisical integration. The inclusion of these tests ensures that the new integration behaves as expected and helps prevent potential issues.
  • New List Function for Available Integrations

    • The integration.go file has been updated to include a new List function. This function gives us a compilation of all available integrations for better visibility. Currently, it includes the newly added dotenv-vault and infisical integrations.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 40.91% and project coverage change: +2.01% 🎉

Comparison is base (cd0bd64) 26.19% compared to head (f6016ee) 28.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   26.19%   28.21%   +2.01%     
==========================================
  Files          18       18              
  Lines        2012     2028      +16     
==========================================
+ Hits          527      572      +45     
+ Misses       1444     1415      -29     
  Partials       41       41              
Files Changed Coverage Δ
lib/app/tasks.go 12.27% <25.00%> (+12.27%) ⬆️
lib/app/workflow.go 11.74% <44.44%> (+11.74%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant