better message, arguably

perkee · Feb 3, 2025 · 7cca7a3 · 7cca7a3
1 parent 8d66b24
commit 7cca7a3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/UseHtmlExtraNothing.elm b/src/UseHtmlExtraNothing.elm
@@ -162,7 +162,7 @@ expressionVisitor node context =
                     if ModuleNameLookupTable.moduleNameFor context.lookupTable firstNode == Just [ "Html" ] then
                         ( [ Rule.error
                                 { message = "Replace `Html.text \"\" with Html.Extra.nothing"
-                                , details = [ "We prefer Html.Extra.nothing" ]
+                                , details = [ "We prefer Html.Extra.nothing when we must create an empty node." ]
                                 }
                                 (Node.range node)
                           ]

diff --git a/tests/UseHtmlExtraNothingTest.elm b/tests/UseHtmlExtraNothingTest.elm
@@ -89,7 +89,7 @@ a = Html.text ""
                     |> Review.Test.expectErrors
                         [ Review.Test.error
                             { message = "Replace `Html.text \"\" with Html.Extra.nothing"
-                            , details = [ "We prefer Html.Extra.nothing" ]
+                            , details = [ "We prefer Html.Extra.nothing when we must create an empty node." ]
                             , under = "Html.text \"\""
                             }
                         ]
@@ -107,7 +107,7 @@ a = H.text ""
                     |> Review.Test.expectErrors
                         [ Review.Test.error
                             { message = "Replace `Html.text \"\" with Html.Extra.nothing"
-                            , details = [ "We prefer Html.Extra.nothing" ]
+                            , details = [ "We prefer Html.Extra.nothing when we must create an empty node." ]
                             , under = "H.text \"\""
                             }
                         ]
@@ -125,7 +125,7 @@ a = text ""
                     |> Review.Test.expectErrors
                         [ Review.Test.error
                             { message = "Replace `Html.text \"\" with Html.Extra.nothing"
-                            , details = [ "We prefer Html.Extra.nothing" ]
+                            , details = [ "We prefer Html.Extra.nothing when we must create an empty node." ]
                             , under = "text \"\""
                             }
                         ]
@@ -143,7 +143,7 @@ a = text ""
                     |> Review.Test.expectErrors
                         [ Review.Test.error
                             { message = "Replace `Html.text \"\" with Html.Extra.nothing"
-                            , details = [ "We prefer Html.Extra.nothing" ]
+                            , details = [ "We prefer Html.Extra.nothing when we must create an empty node." ]
                             , under = "text \"\""
                             }
                         ]