Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed callback error on setTimeout in Oled.prototype._waitUntilReady #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed callback error on setTimeout in Oled.prototype._waitUntilReady #3

wants to merge 1 commit into from

Conversation

nOneKzero
Copy link

@nOneKzero nOneKzero commented Mar 23, 2017 •
edited
Loading

i made a small fix regarding the call of tick (and some Upper Case correction) :)

@tuxBurner
Copy link

+1

@ats1080
Copy link

ats1080 commented Apr 11, 2017

+1 made a change to the callback as well. Hopefully these get pulled.

@etobi
Copy link

etobi commented Jun 8, 2017

+1

@hillct
Copy link

hillct commented Nov 29, 2017

+1

For what it's worth I've tested this patch quite thoroughly. It's reliable and solves a significant issue with modern builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nOneKzero @tuxBurner @ats1080 @etobi @hillct