RC #251 - Peripleo components #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aplibre styles to preview.js
…-components into feature/rc251_peripleo_components # Conflicts: # packages/geospatial/src/index.js # yarn.lock
…tware/react-components into feature/rc251_peripleo_components # Conflicts: # yarn.lock
… Webpack configs
…-components into feature/rc251_peripleo_components # Conflicts: # packages/controlled-vocabulary/package.json # packages/geospatial/package.json # packages/semantic-ui/package.json # packages/semantic-ui/webpack.config.js # packages/shared/package.json # packages/user-defined-fields/package.json # packages/visualize/package.json # react-components.json
|
I was finally able to get this to work after re-doing the entire build process. I think the changes likely warrant a |
Makes sense to me! |
rsimon
approved these changes
Mar 1, 2024
This was referenced Mar 4, 2024
…-components into feature/rc251_peripleo_components # Conflicts: # packages/controlled-vocabulary/package.json # packages/geospatial/package.json # packages/semantic-ui/package.json # packages/shared/package.json # packages/user-defined-fields/package.json # packages/visualize/package.json # react-components.json
added 8 commits
March 5, 2024 15:43
…oving yarn "resolutions" from package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request combines the components added in #247, #249, and #250 into several different components. This pull request also creates Storybook stories for all of the new components.
The
LocationMarkercomponent was added to thegeospatialpackage.A new
core-datapackage was created to house all of the Core Data related components. For the time being, this package will be styled using compiled TailwindCSS classes:In the future, we should look to allow a plugin to be created to allow the consuming application(s) to override any themes defined in this library.