RC #291 - Adding "key" prop to FacetTimeline events; Updating events …

…fetching to clear existing events
performant-software · Aug 13, 2024 · 6da17a7 · 6da17a7
1 parent 69daa84
commit 6da17a7
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/packages/core-data/src/components/FacetTimeline.js b/packages/core-data/src/components/FacetTimeline.js
@@ -202,11 +202,18 @@ const FacetTimeline = (props: Props) => {
     clearTimer();
 
     // Reset the timer to fetch the events
-    setTimer(() => (
+    setTimer(() => {
+      setEvents([]);
+
+      const params = {
+        min_year: value[0],
+        max_year: value[1]
+      };
+
       EventsService
-        .fetchAll({ min_year: value[0], max_year: value[1] })
-        .then(onLoad)
-    ));
+        .fetchAll(params)
+        .then(onLoad);
+    });
   }, [onLoad, max, min, value]);
 
   /**
@@ -266,6 +273,7 @@ const FacetTimeline = (props: Props) => {
         >
           { _.map(events, (event) => (
             <Popover.Root
+              key={event.uuid}
               open
             >
               <Popover.Trigger