Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDC #60 - Data Entry Form #92

Merged
merged 17 commits into from
Jan 9, 2024
Merged

Conversation

dleadbetter
Copy link
Contributor

@dleadbetter dleadbetter commented Jan 9, 2024

This pull request refactors the data entry forms based on the designs in #60.

Note: This pull request is dependent on a PR in the react-components repo.

@jamiefolsom and @cblissg - There were a few minor changes that I did not implement due to the amount of time it would have taken to implement vs. the value added. Do we think any of these items are critical for delivering this feature. If not, I can add individual issues for each to be implemented in the future.

  • "Add" buttons on list components are not right aligned
  • Input elements and related records are not 50% width

Place Edit Form

Screenshot 2024-01-09 at 7 07 49 AM
Screenshot 2024-01-09 at 7 08 00 AM

Person Edit Form

Screenshot 2024-01-09 at 7 08 21 AM
Screenshot 2024-01-09 at 7 08 30 AM

dleadbetter added 15 commits December 12, 2023 21:19
…-data-cloud into feature/cdc60_data_entry_form

# Conflicts:
#	client/src/components/CurrentRecordContextProvider.js
#	client/src/components/ProjectModelRelationshipFactory.js
#	client/src/components/ProjectModelRelationshipsFactory.js
#	client/src/hooks/Relationships.js
#	client/src/i18n/en.json
Copy link
Member

@jamiefolsom jamiefolsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dleadbetter dleadbetter merged commit dde625e into develop Jan 9, 2024
@dleadbetter dleadbetter deleted the feature/cdc60_data_entry_form branch January 9, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants