-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDC #60 - Data Entry Form #92
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Updating AssociatedDropdown buttons
…stead of list view
…-data-cloud into feature/cdc60_data_entry_form # Conflicts: # client/src/components/CurrentRecordContextProvider.js # client/src/components/ProjectModelRelationshipFactory.js # client/src/components/ProjectModelRelationshipsFactory.js # client/src/hooks/Relationships.js # client/src/i18n/en.json
…ing RelatedMediaContents button sizes
…-data-cloud into feature/cdc60_data_entry_form
jamiefolsom
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
…-data-cloud into feature/cdc60_data_entry_form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the data entry forms based on the designs in #60.
Note: This pull request is dependent on a PR in the
react-components
repo.@jamiefolsom and @cblissg - There were a few minor changes that I did not implement due to the amount of time it would have taken to implement vs. the value added. Do we think any of these items are critical for delivering this feature. If not, I can add individual issues for each to be implemented in the future.
Place Edit Form
Person Edit Form