Skip to content

Commit

Permalink
[PPLT-1703] Add support for plain_rcw flag (#52)
Browse files Browse the repository at this point in the history
* [FEAT] add support for plain_rcw

* [REFACTOR] update naming

* Update lib/percy/client/snapshots.rb

Co-authored-by: Yash D. Saraf <[email protected]>

* [UPDATE] move disable transformations to builds

* [UPDATE] bump version

* [FIX] bump version + fix gem bug

* [REFACTOR] add new line

* [TEST] updated percy::client::build spec

Co-authored-by: Yash D. Saraf <[email protected]>
Co-authored-by: nilshah98 <[email protected]>
  • Loading branch information
3 people authored Jan 17, 2023
1 parent 63a56b7 commit 1670a1a
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion RELEASING.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

```bash
bundle exec rake build
gem push pkg/percy-client-1.XX.XX.gem
gem push pkg/percy-client-2.XX.XX.gem
```

_The gem cli will prompt you for email and password. Find the
Expand Down
2 changes: 2 additions & 0 deletions lib/percy/client/builds.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ def create_build(options = {})
target_commit_sha = options[:target_commit_sha] \
|| Percy::Client::Environment.target_commit_sha
resources = options[:resources]
disable_transformations = options[:disable_transformations]
parallel_nonce = options[:parallel_nonce] || Percy::Client::Environment.parallel_nonce
parallel_total_shards = options[:parallel_total_shards] \
|| Percy::Client::Environment.parallel_total_shards
Expand Down Expand Up @@ -39,6 +40,7 @@ def create_build(options = {})
'pull-request-number' => pull_request_number,
'parallel-nonce' => parallel_nonce,
'parallel-total-shards' => parallel_total_shards,
'disable-transformations' => disable_transformations,
},
},
}
Expand Down
2 changes: 1 addition & 1 deletion lib/percy/client/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module Percy
class Client
VERSION = '2.0.4'.freeze
VERSION = '2.0.6'.freeze
end
end
2 changes: 1 addition & 1 deletion percy-client.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
spec.require_paths = ['lib']

spec.add_dependency 'faraday', '>= 0.9'
spec.add_dependency 'faraday', '0.17.3'
spec.add_dependency 'excon'
spec.add_dependency 'addressable'

Expand Down
2 changes: 2 additions & 0 deletions spec/lib/percy/client/builds_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
'commit-committer-name' => kind_of(String),
'commit-committer-email' => kind_of(String),
'commit-message' => kind_of(String),
'disable-transformations' => nil,
'pull-request-number' => anything,
'parallel-nonce' => nil,
'parallel-total-shards' => nil,
Expand Down Expand Up @@ -96,6 +97,7 @@
'commit-committer-name' => kind_of(String),
'commit-committer-email' => kind_of(String),
'commit-message' => kind_of(String),
'disable-transformations' => nil,
'pull-request-number' => '123',
'parallel-nonce' => 'nonce',
'parallel-total-shards' => 4,
Expand Down

0 comments on commit 1670a1a

Please sign in to comment.