Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPG-496: trigger reconcile on PerconaPGBackup update #636

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Jan 16, 2024

K8SPG-496 Powered by Pull Request Badge

https://perconadev.atlassian.net/browse/K8SPG-496

DESCRIPTION

Problem:
If the cluster is set to pause: true while the backup is running, the cluster will not pause when the backup is complete.

Cause:
Reconcile doesn't trigger after backup completion.

Solution:
We should add a new watch function that will trigger a reconcile when the PerconaPGBackup resource is updated..

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are the manifests (crd/bundle) regenerated if needed?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@pooknull pooknull marked this pull request as ready for review January 16, 2024 10:18
@JNKPercona
Copy link
Collaborator

Test name Status
custom-extensions passed
demand-backup passed
init-deploy passed
monitoring passed
operator-self-healing passed
scaling passed
scheduled-backup passed
self-healing passed
start-from-backup passed
telemetry-transfer passed
upgrade-minor passed
users passed
We run 12 out of 12

commit: e67c6a1
image: perconalab/percona-postgresql-operator:PR-636-e67c6a145

@hors hors merged commit c55ccc3 into main Jan 16, 2024
14 checks passed
@hors hors deleted the dev/K8SPG-496 branch January 16, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants