CLOUD-869 Inverting the check to test whether the previous build's result is anything other than SUCCESS #1022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
The previous build can be
NOT_BUILT
for which I do not check.Solution:
Inverting the check to test whether the previous build's result is anything other than
SUCCESS
is a cleaner approach. This way, we don’t need to explicitly list all the non-success states (FAILURE
,ABORTED
,UNSTABLE
,NOT_BUILT
), and the code remains robust against any additional statuses Jenkins might introduce in the future.CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
Config/Logging/Testability