Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUD-869 Inverting the check to test whether the previous build's result is anything other than SUCCESS #1022

Merged

Conversation

ptankov
Copy link
Contributor

@ptankov ptankov commented Jan 24, 2025

CLOUD-869 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
The previous build can be NOT_BUILT for which I do not check.

Solution:
Inverting the check to test whether the previous build's result is anything other than SUCCESS is a cleaner approach. This way, we don’t need to explicitly list all the non-success states (FAILURE, ABORTED, UNSTABLE, NOT_BUILT), and the code remains robust against any additional statuses Jenkins might introduce in the future.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@JNKPercona
Copy link
Collaborator

Test name Status
custom-extensions passed
custom-tls passed
demand-backup passed
finalizers passed
init-deploy passed
monitoring passed
one-pod passed
operator-self-healing passed
pitr passed
scaling passed
scheduled-backup passed
self-healing passed
sidecars passed
start-from-backup passed
tablespaces passed
telemetry-transfer passed
upgrade-consistency passed
upgrade-minor passed
users passed
We run 19 out of 19

commit: 8080b38
image: perconalab/percona-postgresql-operator:PR-1022-8080b383d

@ptankov ptankov merged commit 7593bb1 into main Jan 25, 2025
17 checks passed
@ptankov ptankov deleted the CLOUD-869-invert-check-logic-for-unsuccessful-previous-build branch January 25, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants