-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitely pull managed IAM policies #4
Conversation
This may or may not be needed. It seems `iamer` does pull managed policies, but it does not include non-attached policies. Working on that.
So is it still WIP? Because I tried it and it does not seem to dump new policies that were not dumped before. FTR: This PR is gonna cover #3 |
def document(self): | ||
""" | ||
Returns: | ||
unicode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dict?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. Should be a dict.
Yeah. It's still a WIP. I noticed that, too. It wasn't pulling any new policies. I have a feeling, however, that it IS actually supporting managed policies, but not directly. If a managed policy is attached to a user/group, it'll get pulled as an in-line policy. So, effectively, as of now it does not support non-attached managed policies. |
but we have a lot of attached managed policies. |
Correct. And it seems the existing functionality (ignoring this PR) already On Thu, Jun 23, 2016 at 3:54 PM, Laurent Raufaste [email protected]
Zach Himsel |
follow up by email |
@@ -212,6 +258,9 @@ def dump_policies(self): | |||
for policy in group.policies: | |||
policies_to_dump.add(policy) | |||
|
|||
for managed_policy in self.managed_policies: | |||
policies_to_dump.add(policy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
managed_policy
https://app.asana.com/0/46565522415617/108217457072054
This may or may not be needed. It seems
iamer
does pull managedpolicies, but it does not include non-attached policies. Working on
that.