Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitely pull managed IAM policies #4

Closed
wants to merge 2 commits into from
Closed

Conversation

zhimsel
Copy link

@zhimsel zhimsel commented Jun 23, 2016

https://app.asana.com/0/46565522415617/108217457072054

This may or may not be needed. It seems iamer does pull managed
policies, but it does not include non-attached policies. Working on
that.

This may or may not be needed. It seems `iamer` does pull managed
policies, but it does not include non-attached policies. Working on
that.
@lra
Copy link
Member

lra commented Jun 23, 2016

So is it still WIP? Because I tried it and it does not seem to dump new policies that were not dumped before.

FTR: This PR is gonna cover #3

def document(self):
"""
Returns:
unicode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dict?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Should be a dict.

@zhimsel
Copy link
Author

zhimsel commented Jun 23, 2016

Yeah. It's still a WIP. I noticed that, too. It wasn't pulling any new policies. I have a feeling, however, that it IS actually supporting managed policies, but not directly. If a managed policy is attached to a user/group, it'll get pulled as an in-line policy. So, effectively, as of now it does not support non-attached managed policies.

@lra
Copy link
Member

lra commented Jun 23, 2016

but we have a lot of attached managed policies.

@zhimsel
Copy link
Author

zhimsel commented Jun 23, 2016

Correct. And it seems the existing functionality (ignoring this PR) already
gets the managed policies, as long as they're attached to something. We
currently only have two non-attached managed policies.

On Thu, Jun 23, 2016 at 3:54 PM, Laurent Raufaste [email protected]
wrote:

but we have a lot of attached managed policies.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#4 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AFFDm9o3g-E9oj9VEHgR9P-SKnlt1pZxks5qOwCbgaJpZM4I8WRs
.

Zach Himsel
Devops Engineer
The must-attend marketing event of the year is back. Get your ticket now
at: percolate.com/transition

@lra
Copy link
Member

lra commented Jun 24, 2016

follow up by email

@@ -212,6 +258,9 @@ def dump_policies(self):
for policy in group.policies:
policies_to_dump.add(policy)

for managed_policy in self.managed_policies:
policies_to_dump.add(policy)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

managed_policy

@zhimsel zhimsel closed this Jul 18, 2022
@lra lra deleted the managed_policies branch July 18, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants