ci: more verbose request logging #374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
commented
Feb 13, 2025
| @@ -17,6 +17,7 @@ | |||
| jq | |||
| just | |||
| pnpm | |||
| nodejs_22 | |||
There was a problem hiding this comment.
This change just ensures a compatible version of nodejs is included in the nix dev env, which I use to manage the tooling locally.
When fetching external URLs, notably the Registry JSON, we want to see in the logs whether that's a cache hit or miss. Tweaking the logging config to allow just that. Also includes some references to config options that we can only enable once we upgrade to NextJS v15.
cronokirby
force-pushed
the
better-fetch-logging
branch
from
c59719b to
0accdee
Compare
cronokirby
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fetching external URLs, notably the Registry JSON, we want to see in the logs whether that's a cache hit or miss. Tweaking the logging config to allow just that.
Also includes some references to config options that we can only enable once we upgrade to NextJS v15. See relevant docs here: https://nextjs.org/docs/app/api-reference/config/next-config-js/logging
These changes were made while investigating #373. Given that it pertains to logging, also relevant to #352.
Example logs before
Example logs after