feat(accounts): Allow disabling email sending to unknown addresses #3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riconnon
force-pushed
the
no-unknown-account-emails
branch
2 times, most recently
from
ad93496 to
c500e18
Compare
pennersr
requested changes
Nov 27, 2023
| @@ -88,6 +88,28 @@ def test_password_forgotten_no_username_hint(self): | |||
| body = mail.outbox[0].body | |||
| assert user.username not in body | |||
|
|
|||
| @override_settings( | |||
There was a problem hiding this comment.
These are old style unit tests. We're in a transition to pytest and should not be introducing new legacy tests.
There was a problem hiding this comment.
I'll look to move these over.
riconnon
force-pushed
the
no-unknown-account-emails
branch
3 times, most recently
from
9a86397 to
265af59
Compare
riconnon
force-pushed
the
no-unknown-account-emails
branch
from
265af59 to
c6ea6bf
Compare
pennersr
requested changes
Dec 7, 2023
pennersr
reviewed
Dec 7, 2023
riconnon
force-pushed
the
no-unknown-account-emails
branch
2 times, most recently
from
3f2291c to
cf97713
Compare
Add a setting to the accounts app which disables sending emails to addresses which do not have an account. For many sites this behaviour will be undesirable since it sends potentially unsolicited email to someone who has not shared it with us.
riconnon
force-pushed
the
no-unknown-account-emails
branch
from
cf97713 to
83bf9fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a setting to the accounts app which disables sending emails to addresses which do not have an account.
For many sites this behaviour will be undesirable since it sends potentially unsolicited email to someone who has not shared it with us.
Submitting Pull Requests
General
Examples:
"fix(google): Fixed foobar bug","feat(accounts): Added foobar feature".ChangeLog.rst.AUTHORS.Provider Specifics
In case you add a new provider:
test_settings.py::INSTALLED_APPSanddocs/installation.rst::INSTALLED_APPS.docs/providers/<provider name>.rstanddocs/providers/index.rstProvider Specifics toctree.docs/overview.rst.