Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image-hd: gpt: add type GUID shortcut for barebox-env #245

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

a3f
Copy link
Member

@a3f a3f commented Apr 3, 2024

barebox has been documenting a dedicated GPT partition type GUID for
barebox environment partitions for a while and has started
making actual use of it at runtime in its v2024.03.0 release.

Add a shorthand to make it easier to use.

@a3f a3f requested a review from rohieb April 3, 2024 16:44
Copy link
Contributor

@rohieb rohieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ther rest looks correct.

README.rst Show resolved Hide resolved
@rohieb rohieb changed the title mage-hd: gpt: add type GUID shortcut for barebox-env image-hd: gpt: add type GUID shortcut for barebox-env Apr 3, 2024
a3f added 2 commits April 4, 2024 09:24
Follow-up commit will add a barebox-env type GUID, so the plain
B shortcut will become confusing. In future, there might be even a
partition type GUID for the barebox binary itself making this even more
ambiguous. Avoid the confusion by just removing the B shorthand.

Signed-off-by: Ahmad Fatoum <[email protected]>
barebox has been documenting a dedicated GPT partition type GUID for
barebox environment partitions for a while[1] and has started
making actual use of it at runtime in its v2024.03.0 release[2][3].

Add a shorthand to make it easier to use.

[1]: barebox/barebox@ef25a0ce960d
[2]: barebox/barebox@9f868f78bc54
[3]: barebox/barebox@287bd01a6a26

Signed-off-by: Ahmad Fatoum <[email protected]>
Copy link
Member

@michaelolbrich michaelolbrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@michaelolbrich michaelolbrich merged commit 6545138 into master Apr 4, 2024
7 checks passed
@a3f a3f deleted the barebox-env branch April 4, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants