Version 2.0 #25
Merged
Version 2.0 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==============================================
- Coverage 100.00% 67.68% -32.32%
- Complexity 33 65 +32
==============================================
Files 2 4 +2
Lines 82 164 +82
==============================================
+ Hits 82 111 +29
- Misses 0 53 +53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pelmered
commented
Feb 2, 2024
tests/FakeCarTest.php
Outdated
Comment on lines
221
to
222
| //$result6 = $this->assertCount(1, $this->callProtectedMethod([$data], 'getRandomElementsFromArray')); | ||
| //$result6 = $this->callProtectedMethod([$data, null], 'getRandomElementsFromArray'); |
tests/FakeCarTest.php
Outdated
| } | ||
|
|
||
| public function testVehicleFuelType() | ||
| { | ||
| $this->assertTrue(in_array($this->faker->vehicleFuelType, CarData::getVehicleFuelTypes())); | ||
| //dd($this->faker->vehicleFuelType, FakeCarData::$vehicleFuelTypes); |
tests/FakeCarTest.php
Outdated
| public function callProtectedMethod($args, $method, $object = null) | ||
| { | ||
| if (is_null($object)) { | ||
| //$object = new FakeCar($this->faker); |
tests/FakeCarTest.php
Outdated
| if (is_null($class)) { | ||
| $class = new Fakecar($this->faker); | ||
| if (is_null($object)) { | ||
| //$object = new FakeCar($this->faker); |
| 2. The provider name has changed from `Fakear` to `FakeCar`. This will cause problems if you are on a case-sensitive filesystem, but it is strongly recommended to change this even if you are not. | ||
| 3. The methods `transliterate` and `checkDigit` on the `FakeCar` provider class are now no longer publicly available (Visibility changed to private). | ||
| 4. The public methods `getRandomElementsFromArray` and `getWeighted` on the `FakeCar` provider class has been moved to a helper class. Access them like this: `\Faker\Provider\FakeCarHelper::getWeighted` | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.