Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Health ScheduleCheck #999

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Fix Health ScheduleCheck #999

merged 2 commits into from
Feb 11, 2025

Conversation

RMartinOscar
Copy link
Contributor

panel/app/Console/Kernel.php

Line 59 in a6963ad

$schedule->command(ScheduleCheckHeartbeatCommand::class)->everyMinute();
Will always fail cause it checks if ScheduleCheck is registered
image

image

@RMartinOscar RMartinOscar requested a review from a team as a code owner February 11, 2025 21:02
@RMartinOscar RMartinOscar changed the title Fix ScheduleCheck instead of a blank Check Fix Health ScheduleCheck Feb 11, 2025
@RMartinOscar RMartinOscar added the 🐛 bug Something isn't working label Feb 11, 2025
@RMartinOscar RMartinOscar merged commit 8f47ccf into main Feb 11, 2025
22 checks passed
@RMartinOscar RMartinOscar deleted the fix/HealthScheduleCheck branch February 11, 2025 21:11
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Boy132 Boy132 Boy132 approved these changes

@notAreYouScared notAreYouScared Awaiting requested review from notAreYouScared

@alexevladgabriel alexevladgabriel Awaiting requested review from alexevladgabriel

Assignees
No one assigned
Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RMartinOscar @Boy132