Add tests for module exports #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps ensure that in the future we don't break anything that depends on this module by exporting something that doesn't exist.
|
@Joxit I think your PR has become the new |
|
If we merge this PR and #498 then your PR should be good to go. It should be a nice big new major version! |
|
Ha ha yes, this was a nice catch 😅 Here we go ! The PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR into #487 which adds some unit tests covering the shared resources exported by this module. We've been bitten many times in the past by removing code and forgetting to update
index.js. This should help with that going forward.It also fixes some that were just recently missed :)