Fix ignoring dataHost and maxDownloads options #484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Any updates on this small PR? I hope it can be merged without any issues as it's just small fix. |
Summary of changes: 1. Fix hardcoded REMOTE variable in sqlite_download.sh and updated sqlite_download.js to send dataHost to bash script. 2. Update README to show correct default dataHost value
|
Hi @loadit1, I just rebased this PR against the latest changes in the master branch and did a little cleanup. I think it's good to go, but will do a little bit more testing before merging! Thanks for taking the time to submit it. |
Merged
|
Hi! We've done a bunch of housecleaning and as of #487 this PR should no longer be needed: we've removed a lot of downloader code and all the code that remains uses the If there's anything that still doesn't work let us know and open an issue! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
dataHostwhile callsqlite_download.shdataHostURLmaxDownloadsinsqlite_download.js