Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI updates: Modern Node.js versions, action version updates, standard template #137

Merged
merged 5 commits into from
Dec 3, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions .github/workflows/_test.yml
Original file line number Diff line number Diff line change
@@ -6,18 +6,16 @@ jobs:
strategy:
matrix:
os:
- ${{ vars.UBUNTU_VERSION }}
node-version:
- 12.x
- 14.x
- 16.x
- ubuntu-22.04
node-version: [ 18.x, 20.x, 22.x ]
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: 'Install node.js ${{ matrix.node-version }}'
uses: actions/setup-node@v2-beta
uses: actions/setup-node@v4
with:
node-version: '${{ matrix.node-version }}'
- name: Run unit tests
run: |
[[ -f ./bin/ci-setup ]] && ./bin/ci-setup
npm install
npm run ci
22 changes: 4 additions & 18 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
@@ -6,13 +6,13 @@ jobs:
npm-publish:
needs: unit-tests
if: github.ref == 'refs/heads/master' && needs.unit-tests.result == 'success'
runs-on: ${{ vars.UBUNTU_VERSION }}
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Install Node.js
uses: actions/setup-node@v2-beta
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x
- name: Run semantic-release
env:
GH_TOKEN: ${{ secrets.GH_SEMANTIC_RELEASE_TOKEN }}
@@ -21,17 +21,3 @@ jobs:
if [[ -n "$GH_TOKEN" && -n "$NPM_TOKEN" ]]; then
curl "https://raw.githubusercontent.com/pelias/ci-tools/master/semantic-release.sh" | bash -
fi
build-docker-images:
# run this job if the unit tests passed and the npm-publish job was a success or was skipped
# note: github actions won't run a job if you don't call one of the status check functions, so `always()` is called since it evalutes to `true`
if: ${{ always() && needs.unit-tests.result == 'success' && (needs.npm-publish.result == 'success' || needs.npm-publish.result == 'skipped') }}
needs: [unit-tests, npm-publish]
runs-on: ${{ vars.UBUNTU_VERSION }}
steps:
- uses: actions/checkout@v2
- name: Build Docker images
env:
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
run: |
curl "https://raw.githubusercontent.com/pelias/ci-tools/master/build-docker-images.sh" | bash -