-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bzip2 to lbzip2 migration to use all CPU cores #173
Conversation
Summary of changes: If lbzip2 installed on system we use it. If not, using legacy bzip2. Updated Dockerfile to install lbzip2
On the warpath ;) See pelias/whosonfirst#480 (comment), if you re-open this on a new branch within our org then docker images will be automatically generated for testing 🎉 |
The test failures may be unrelated to your work, we recently moved the CDN assets:
I'll check it out and let you know |
I just merged #174, please rebase origin/master to pull in a fix for the Travis test failure. |
Summary of changes: If lbzip2 installed on system we use it. If not, using legacy bzip2. Updated Dockerfile to install lbzip2
@missinglink sure, done. |
@missinglink done, please let me know if you still see some issues with indentation and I'll try to fix them if so. Thank you! |
Found that everything ready to use |
Hello! Please let me know if this PR can be merged or you need any action from my side? Thank you! |
Sorry I didn't get back to you. I got mentally stuck on adding the I'm also not quite clear on how the code used to work without this? The reason I'm worried is that I've had both successes and deflated failures using the The rest of the PR looks fine to me. |
Agh ok so I remember now, the scripts which reference Most people just download the data from Geocode Earth so they don't use these scripts. Yea, I think it's fine to add these, I checked our build server and we do this before running the scripts:
Is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, took me a while but this should be fine
@missinglink Thanks a lot! As far I can see, |
Summary of changes:
lbzip2
installed on system we use it. If not, using legacybzip2
.Dockerfile
to installlbzip2
andparallel
Related to discussion about issue 480 in
pelias/whosonfirst
Related also to #142 #143