-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for custom envFrom #673
base: master
Are you sure you want to change the base?
Conversation
Added support for .custom.envFrom so for example you can reference to secrets when further templating context.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any documentation for how a client will use this additional setting? I would think we need additional details in the pega readme.
Hi @taz-pega-work i just added some documentation in the Readme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! thanks @MathijsFra !!!!!
@MathijsFra Can you please add unit tests for the new feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests for the new feature are required.
@MathijsFra Can you create github issue for the requirement and link it here? Provide the required details about the current issue/use case and other details? |
Added support for .custom.envFrom so for example you can reference to secrets when further templating context.xml