Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for custom envFrom #673

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MathijsFra
Copy link

Added support for .custom.envFrom so for example you can reference to secrets when further templating context.xml

Added support for .custom.envFrom so for example you can reference to secrets when further templating context.xml
@MathijsFra MathijsFra requested a review from a team as a code owner November 27, 2023 10:29
Copy link
Contributor

@taz-pega-work taz-pega-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any documentation for how a client will use this additional setting? I would think we need additional details in the pega readme.

@MathijsFra
Copy link
Author

Hi @taz-pega-work i just added some documentation in the Readme

Copy link
Contributor

@taz-pega-work taz-pega-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks @MathijsFra !!!!!

@MadhuriArugula
Copy link
Collaborator

@MathijsFra Can you please add unit tests for the new feature.

Copy link
Collaborator

@MadhuriArugula MadhuriArugula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests for the new feature are required.

@kishorv10
Copy link
Contributor

@MathijsFra Can you create github issue for the requirement and link it here? Provide the required details about the current issue/use case and other details?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants