Support for compile time disabling of SPD #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…soldered memory chips) Patch also includes cleanup of spd module interface allowing for its clean disabling. Changes: - Add SPD_DISABLED config option (config.h) - Cleanup of spd module interface (movinf all private functions and variables do spd.c) - Disable spd code when SPD_DISABLED option is set (spd.c) - Hide 'Display SPD Data' option on the configuration screen is SPD_DISABLED (display.c)
|
@pandrej I'm not sure if we should do anything with that ? It looks mostly like clean up, do you want to push this to mailing list ? |
|
Looks fine to me. We should try to mainline it and in the meantime we should use this implementation in Pcengines releases. In the future we may think about some way of getting the spd data directly from cbfs. It looks like a standard way for coreboot to incorporate spd data on platform without physical spd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(needed for platforms with soldered memory chips)
Patch includes cleanup of spd module interface allowing for its clean disabling.
Changes: