Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding one more target for TM1K4 #1305

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

tongju12
Copy link
Contributor

@tongju12 tongju12 commented Nov 8, 2024

TMO add one more SiN target into TM1K4 so it is up to 9 targets including OUT

target number changes from 8 to 9

Motivation and Context

TMO laser scientists put a new paddle and it holds 9 targets instead of 8.

How Has This Been Tested?

GUI works already.

Where Has This Been Documented?

https://jira.slac.stanford.edu/browse/ECS-6744

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@tongju12 tongju12 requested a review from tangkong November 8, 2024 18:09
Copy link
Contributor

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works in conjunction with pcdshub/lcls-plc-tmo-motion#136


Contributors
------------
- @tongju12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- @tongju12
- tongju12

@tongju12 tongju12 merged commit de51a21 into pcdshub:master Nov 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants