Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add class for mr1l1 #1175

Merged
merged 3 commits into from
Oct 16, 2023
Merged

ENH: add class for mr1l1 #1175

merged 3 commits into from
Oct 16, 2023

Conversation

nrwslac
Copy link
Contributor

@nrwslac nrwslac commented Oct 11, 2023

Description

  • add class XOffsetMirrorNoBend for mr1l1

Motivation and Context

  • mr1l1 installed on the beamline

How Has This Been Tested?

  • launched a typhos screen for MR1L1:HOMS.

Where Has This Been Documented?

https://jira.slac.stanford.edu/browse/ECS-1222

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implies that we should refactor the mirror classes at some point to have a more straightforward inheritance, but it doesn't have to be now.

The implementation looks normal to me and the docstring is clear.

@nrwslac nrwslac merged commit 1b9596b into pcdshub:master Oct 16, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants