Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: update url used to grab tag information #352

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

tangkong
Copy link
Contributor

@tangkong tangkong commented Jan 7, 2025

Closes #351

Simply changes the url used to get package tag information. The old one seems to have died.

Tested by running this function on slac-alarm-manager (the failing case) and happi (the case I trusted to be working)

In [1]: from scripts.update_tags import pypi_latest_version_no_search

In [2]: pypi_latest_version_no_search("happi")
Out[2]: '2.6.0'

In [3]: pypi_latest_version_no_search("slac-alarm-manager")
Out[3]: '1.3.0'

@tangkong tangkong requested a review from ZLLentz January 7, 2025 23:37
@tangkong
Copy link
Contributor Author

tangkong commented Jan 7, 2025

Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working via comparing the CI (it fails later now)
Thank you for noticing, diagnosing, and fixing. I noticed but didn't look any closer.

@ZLLentz ZLLentz merged commit 925c3ec into pcdshub:master Jan 8, 2025
3 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pypi_latest_version_no_search fails to find any package, even those on pypi
2 participants