Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX TD400 Serial driver-setting turbo frequency #17

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

janezg-SLAC
Copy link
Contributor

Description

Updating TD400 serial driver. Program waits until communication is established and then control parameter to set freq. gets updated with value from controller. After that program checks if user updated the control parameter to set freq and sends request to change frequency to controller.

Also updating conversion for Current and Power.

Motivation and Context

On PLC reboot program requested to change frequency on controller every time and set it always to minimum frequency.

How Has This Been Tested?

Function has been tested with DREAM PLC which has 4 of these TD400 controllers. Tried to reboot PLC, removed serial cable from pump controller and reconnect it back and program always update our control parameter with value from controller.

Where Has This Been Documented?

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to Always Newest version (Library, *)
  • Committed with pre-commit or ran pre-commit run --all-files

@janezg-SLAC janezg-SLAC requested a review from jyin999 November 22, 2024 01:16
@janezg-SLAC janezg-SLAC merged commit bc7c7a3 into pcdshub:master Dec 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants