Serial Library for Leybold TD400 controller #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new function block to support leybold TD400 controller serial communication. New driver is needed because TD400 controller doesn't have available parameter P21. Also it was requested by Jing to add function to change the speed of the pump. I removed parameter P21 and add reading of parameters P18(max speed) and P19 (min speed) which will help us to limit the input from the user.
Motivation and Context
How Has This Been Tested?
Where Has This Been Documented?
Pre-merge checklist
Always Newestversion (Library, *)pre-commitor ranpre-commit run --all-files