Implement SteamGuard authentication #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new optional column is read in the CSV file to specify with which TOTP the line must be computed. The implementation is based on the work done in the SailOTP application available on github.com/seiichiro0185/sailotp
|
Sorry for the crazy lag, no excuse. Nice contribution, if you'd like to rebase happy to reconsider for a merge, otherwise might steal later. |
pcarrier
reviewed
Jan 29, 2021
| @@ -57,12 +58,28 @@ func AuthCode(sec string, ts int64) (string, error) { | |||
| offset := hash[19] & 0x0f | |||
| trunc := hash[offset : offset+4] | |||
| trunc[0] &= 0x7F | |||
| res := new(big.Int).Mod(new(big.Int).SetBytes(trunc), big.NewInt(1000000)) | |||
| return fmt.Sprintf("%06d", res), nil | |||
| if strings.TrimSpace(encodeType) == "Steam" { | |||
There was a problem hiding this comment.
Nit: case-insensitive seems better?
|
FWIW, if you do want to go ahead with this change, I added an extension point to the That should make it a little easier to integrate with code generation. This is also tangentially related to #33 in that it requires extending the config format. (One idea: A provider of |
|
What's the status? Happy to ship once it's mergeable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new optional column is read in the CSV file to specify with which TOTP the line must be computed.
The implementation is based on the work done in the SailOTP application available on https://github.com/seiichiro0185/sailotp