Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-8646 Allow Mojarra to Initialise Weld / Cannot Deploy Sprint Boot 3 #543

Open
wants to merge 1 commit into
base: main-6
Choose a base branch
from

Conversation

Pandrex247
Copy link
Member

Copy link
Contributor

@fturizo fturizo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs a minor layout fix.

@@ -167,8 +167,11 @@ asadmin-options::
To preserve active sessions, Payara Server serializes the sessions and saves them in memory. To restore the sessions, the class loader of the newly redeployed application deserializes any sessions that were previously saved.
`preserveAppScopedResources`;;
If set to `true`, preserves any application-scoped resources and restores them during redeployment. Default is `false`. +
Other available properties are determined by the implementation of the component that is being redeployed. +
For components packaged as OSGi bundles (`--type=osgi`), the `deploy` subcommand accepts properties arguments to wrap a WAR file as a WAB (Web Application Bundle) at the time of deployment. The subcommand looks for a key named `UriScheme` and, if present, uses the key as a URL stream handler to decorate the input stream. Other properties are used in the decoration process. For example, the Payara Server OSGi web container registers a URL stream handler named `webbundle`, which is used to wrap a plain WAR file as a WAB. For more information about usage, see the example in this help page.
`allowFacesCdiInitialisation={false|true}`;;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pandrex247, it seems that you put the text for the new property right in the middle of the paragraph for the text of the preserveAppScopedResources splitting its definition and breaking the layout, I recommend moving the paragraph for the allowFacesCdiInitialisation property after the full text of the preserveAppScopedResources property.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks correct to me?
https://jenkins.payara.fish/view/Documentation/job/Payara-Documentation%20PR%20Deploy%20Preview/view/change-requests/job/PR-543/Community_20Documentation/

The text about "other available properties..." is not part of the description of preserveAppScopedResources - it's an addendum to the overall --properties option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants