Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge "feature/keyboard" #94

Merged
merged 12 commits into from
Sep 6, 2024
Merged

Merge "feature/keyboard" #94

merged 12 commits into from
Sep 6, 2024

Conversation

Charles-Mahoudeau
Copy link
Member

No description provided.

Introduce a trackpad area for cursor control within the keyboard interface. Added functions for trackpad updates and interaction handling, enabling and disabling the trackpad based on user input.
Enhanced the `Label` class to support cursor functionalities with new methods for enabling/disabling and setting cursor position. Updated the text parsing to accurately track cursor indices and display them correctly, along with minor improvements in `Keyboard` handling.
Standardize spacing around pointers and braces to improve code readability and maintain consistency. This change affects various functions and declarations in both `Keyboard.hpp` and `Keyboard.cpp`. These adjustments will make the code more uniform and easier to understand for future contributors.
Implemented cursor-based character insertion and removal in the buffer. Enhanced trackpad functionality to enable precise cursor movement and updated visual feedback.
Changed cursor index type from uint16_t to int16_t for better handling of negative values. Added boundary checks to ensure cursor index is within the valid range of text length.
Introduced a new Filter class to apply graphical effects on GUI elements. Updated Keyboard element to use Filter instead of Canvas for better trackpad handling. Adjusted Surface methods to support filter application.
Move FT6236G header inclusion and initialization from graphics.hpp to graphics.cpp to improve encapsulation and reduce header dependencies. This change ensures that FT6236G is only included when needed and prevents potential conflicts or compilation issues.
Introduce trackpad active icon to improve visual feedback when the trackpad is active. Replace trackpad filter with a trackpad active box for better performance and simplicity. Update initialization and handling logic to accommodate the new trackpad active icon.
# Conflicts:
#	lib/graphics/src/graphics.cpp
#	lib/graphics/src/graphics.hpp
#	lib/gui/src/ElementBase.cpp
#	lib/gui/src/elements/Label.cpp
# Conflicts:
#	lib/graphics/src/Surface.cpp
#	lib/gsm/src/gsm.hpp
@Charles-Mahoudeau Charles-Mahoudeau merged commit c740d55 into main Sep 6, 2024
8 checks passed
@Charles-Mahoudeau Charles-Mahoudeau deleted the feature/keyboard branch September 6, 2024 07:11
Copy link
Contributor

@paxo-rch paxo-rch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est bon pour moi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants