-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge "feature/keyboard" #94
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a trackpad area for cursor control within the keyboard interface. Added functions for trackpad updates and interaction handling, enabling and disabling the trackpad based on user input.
Enhanced the `Label` class to support cursor functionalities with new methods for enabling/disabling and setting cursor position. Updated the text parsing to accurately track cursor indices and display them correctly, along with minor improvements in `Keyboard` handling.
Standardize spacing around pointers and braces to improve code readability and maintain consistency. This change affects various functions and declarations in both `Keyboard.hpp` and `Keyboard.cpp`. These adjustments will make the code more uniform and easier to understand for future contributors.
Implemented cursor-based character insertion and removal in the buffer. Enhanced trackpad functionality to enable precise cursor movement and updated visual feedback.
Changed cursor index type from uint16_t to int16_t for better handling of negative values. Added boundary checks to ensure cursor index is within the valid range of text length.
Introduced a new Filter class to apply graphical effects on GUI elements. Updated Keyboard element to use Filter instead of Canvas for better trackpad handling. Adjusted Surface methods to support filter application.
Move FT6236G header inclusion and initialization from graphics.hpp to graphics.cpp to improve encapsulation and reduce header dependencies. This change ensures that FT6236G is only included when needed and prevents potential conflicts or compilation issues.
Introduce trackpad active icon to improve visual feedback when the trackpad is active. Replace trackpad filter with a trackpad active box for better performance and simplicity. Update initialization and handling logic to accommodate the new trackpad active icon.
# Conflicts: # lib/graphics/src/graphics.cpp # lib/graphics/src/graphics.hpp # lib/gui/src/ElementBase.cpp # lib/gui/src/elements/Label.cpp
# Conflicts: # lib/graphics/src/Surface.cpp # lib/gsm/src/gsm.hpp
paxo-rch
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est bon pour moi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.