Test and refactor GetUserInfoFromToken
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main changes are: 1. Error handling: Instead of using `log.Fatal` which will terminate the program, the function now returns an error which can be handled by the caller. 2. HTTP request: The token is now sent in the Authorization header instead of the query string, which is a more secure practice. 3. JSON decoding: Instead of reading the entire response body into a byte slice and then decoding it, the function now decodes the JSON directly from the response body.
…he token in url Because I am not sure the safer method, sending the token in Authorization header, is supported by the server.
minottic
reviewed
May 17, 2024
sbliven
approved these changes
May 24, 2024
|
Looks good other than the compile error. |
|
@consolethinks if you have any free time, could you check and fix this PR (or close it all together if not relevant to your changes)? |
Sure I'll check on it today or next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.