Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test GetAvailableDatasets #61

Merged
merged 5 commits into from
May 22, 2024
Merged

test GetAvailableDatasets #61

merged 5 commits into from
May 22, 2024

Conversation

kavir1698
Copy link
Contributor

Testing the case where singleDatasetId is empty is not straightforward.

kavir1698 added 3 commits May 6, 2024 13:32
@kavir1698
Add docstring and a basic test
42b3493 
Testing the case where singleDatasetId is empty is not straightforward.
@kavir1698
Refactor and add more tests
fe7392e 
Change how `GetAvailableDatasets` it is called.
@kavir1698
Bring the message to the users back
f54f9c1
minottic
minottic approved these changes May 17, 2024
View reviewed changes
datasetUtils/getAvailableDatasets.go Outdated Show resolved Hide resolved
@kavir1698 kavir1698 merged commit bcce3b0 into main May 22, 2024
3 checks passed
@kavir1698 kavir1698 deleted the test-GetAvailableDatasets branch May 22, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minottic minottic minottic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kavir1698 @minottic