Add test for checkMetadata function #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minottic
reviewed
Feb 27, 2024
sbliven
requested changes
Feb 27, 2024
kavir1698
force-pushed
the
checkMetadata_test
branch
from
c5b3334 to
629d072
Compare
Merged
minottic
reviewed
Mar 25, 2024
minottic
approved these changes
Mar 26, 2024
|
There is one change request from @sbliven that's blocking the merge, but I can't find it 🤔 |
|
Spencer has to approve the changes were made, otherwise it's blocked |
sbliven
approved these changes
Mar 27, 2024
kavir1698
added a commit
that referenced
this pull request
Mar 27, 2024
* Add test - not passing * Add comments and testdata dir * Make the tests pass. * Add more tests * Mark a line for future improvement
kavir1698
added a commit
that referenced
this pull request
Mar 27, 2024
* Add test - not passing * Add comments and testdata dir * Make the tests pass. * Add more tests * Check illegal characters * Fix the tests * Add test for checkMetadata function (#4) * Add test - not passing * Add comments and testdata dir * Make the tests pass. * Add more tests * Mark a line for future improvement * Bump golang.org/x/crypto from 0.3.0 to 0.17.0 (#19) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.3.0 to 0.17.0. - [Commits](golang/crypto@v0.3.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add dummy email --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this test is merged, I will refactor the function and add checks to address #9