Add instructions to compile binaries #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add instructions to compile binaries Change loop syntax for Windows builds Fix typo Fix variable declaration Update the build command for Windows Fix the APPS list for PowerShell
|
@minottic Can you check again please? This commits are squashed. |
minottic
approved these changes
Mar 6, 2024
minottic
reviewed
Mar 6, 2024
Since deploying and creating a new release are typically actions you would want to do after code has been reviewed and merged, triggering on a pull request results to errors.
minottic
approved these changes
Mar 14, 2024
|
We have to tag the main branch after this PR is merged for the releases to be created. What would you choose as the version of the whole package? v1.0.0? or 0.1.0? |
|
I would do 0.1.0 for the moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests fail because the changes in #1 need to be merged first.