Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CheckForNewVersion to use the GitHub location #18

Merged
merged 11 commits into from
Mar 26, 2024

Conversation

kavir1698
Copy link
Contributor

Will address point 3 on #10

@kavir1698 kavir1698 requested a review from a team March 25, 2024 14:44
Copy link
Collaborator

@minottic minottic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! the tests are very nicely written IMHO!

datasetUtils/checkForNewVersion.go Outdated Show resolved Hide resolved
datasetUtils/checkForNewVersion.go Outdated Show resolved Hide resolved
datasetUtils/checkForNewVersion.go Outdated Show resolved Hide resolved
datasetUtils/checkForNewVersion.go Outdated Show resolved Hide resolved
datasetUtils/checkForNewVersion_test.go Outdated Show resolved Hide resolved
datasetUtils/checkForNewVersion_test.go Outdated Show resolved Hide resolved
datasetUtils/checkForNewVersion_test.go Show resolved Hide resolved
datasetUtils/checkForNewVersion_test.go Outdated Show resolved Hide resolved
datasetUtils/checkForNewVersion_test.go Show resolved Hide resolved
datasetUtils/checkForNewVersion.go Outdated Show resolved Hide resolved
@minottic minottic self-requested a review March 26, 2024 13:23
@kavir1698 kavir1698 merged commit aa8c0e4 into main Mar 26, 2024
2 checks passed
@kavir1698 kavir1698 deleted the change-version-check branch March 26, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants