Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update userpass login method for v4 backend #117

Closed
wants to merge 2 commits into from

Conversation

consolethinks
Copy link
Collaborator

It fixes/updates the login method for v4 backend, as the new final endpoint for it is /auth/login instead of /users/login

Copy link
Member

@minottic minottic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, thanks! some comments on tests

cmd/commands/authenticate.go Show resolved Hide resolved
datasetUtils/authenticateUser.go Outdated Show resolved Hide resolved
@@ -36,7 +36,8 @@ func AuthenticateUser(client *http.Client, APIServer string, username string, pa
return map[string]string{}, []string{}, err
}
defer resp.Body.Close()
if resp.StatusCode == 200 {

if resp.StatusCode == 201 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it accept 2xx?

@minottic minottic self-requested a review January 28, 2025 11:37
@consolethinks
Copy link
Collaborator Author

I'm going to drop this PR as I decided to rewrite the login function instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants