fix GetUserInfoFromToken for v4 of backend #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbliven
reviewed
Jan 15, 2025
| @@ -54,12 +54,12 @@ func GetUserInfoFromToken(client *http.Client, APIServer string, token string) ( | |||
| if err != nil { | |||
| return map[string]string{}, []string{}, err | |||
| } | |||
| req2, err := http.NewRequest("GET", APIServer+"/users/"+url.QueryEscape(newUserInfo.Id)+"/userIdentity", nil) | |||
| filterString := url.QueryEscape(fmt.Sprintf("{\"where\":{\"userId\":\"%s\"}}", newUserInfo.Id)) | |||
There was a problem hiding this comment.
The docs say
{
"where?": {
"profile.email": "[email protected]"
}
}
This last version is deprecated and will be discontinued as soon as the FE is updated.
It has been maintanined for backward compatibility.
Looks like it shouldn't have the 'where' clause.
There was a problem hiding this comment.
I copied this solution from the frontend I think, but I'll recheck with the original method for v3.
| @@ -54,12 +54,12 @@ func GetUserInfoFromToken(client *http.Client, APIServer string, token string) ( | |||
| if err != nil { | |||
| return map[string]string{}, []string{}, err | |||
| } | |||
| req2, err := http.NewRequest("GET", APIServer+"/users/"+url.QueryEscape(newUserInfo.Id)+"/userIdentity", nil) | |||
There was a problem hiding this comment.
This endpoint seems to still exist (at least in release-jobs). What's the issue here?
|
This change is not necessary anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It updates the GetUserInfoFromToken function to properly interact with scicat backend v4.