Fix bugs that prevent tests from passing

.gitignore

@@ -1 +1,3 @@
-build
+build
+*.un~
+*~

cmd/datasetIngestor/main.go

@@ -281,7 +281,7 @@ func main() {
 		} else if numFiles > TOTAL_MAXFILES {
 			tooLargeDatasets++
 			color.Set(color.FgRed)
-			log.Println("This dataset exceeds the current filecount limit of the archive system of %v files and will therefore NOT be stored.\n", TOTAL_MAXFILES)
+			log.Printf("This dataset exceeds the current filecount limit of the archive system of %v files and will therefore NOT be stored.\n", TOTAL_MAXFILES)
 			color.Unset()
 		} else {
 			datasetIngestor.UpdateMetaData(client, APIServer, user, originalMap, metaDataMap, startTime, endTime, owner, tapecopies)

cmd/datasetRetriever/main.go

@@ -95,7 +95,7 @@ func main() {
 	log.Printf("You are about to retrieve dataset(s) from the === %s === retrieve server...", env)
 	color.Unset()
 
-	if *retrieveFlag == false {
+	if !*retrieveFlag {
 		color.Set(color.FgRed)
 		log.Printf("Note: you run in 'dry' mode to simply check which data would be fetched.\n")
 		log.Printf("Use the -retrieve flag to actually transfer the datasets to your chosen destination path.\n")
@@ -126,7 +126,7 @@ func main() {
 
 	if len(datasetList) == 0 {
 		fmt.Printf("\n\nNo datasets found on intermediate cache server.\n")
-		fmt.Println("Did you submit a retrieve job from the data catalog first ?\n")
+		fmt.Println("Did you submit a retrieve job from the data catalog first ?")
 	} else {
 		// get sourceFolder and other dataset related info for all Datasets
 		datasetDetails := datasetUtils.GetDatasetDetails(client, APIServer, user["accessToken"], datasetList, *ownerGroup)

datasetIngestor/assembleFilelisting.go

@@ -118,7 +118,7 @@ func AssembleFilelisting(sourceFolder string, filelistingPath string, skip *stri
 		// spin.Start() // Start the spinner
 		e := filepath.Walk(line, func(path string, f os.FileInfo, err error) error {
 			// ignore ./ (but keep other dot files)
-			if f == nil || f.IsDir == nil || f.Name == nil {
+			if f == nil || !f.IsDir() || f.Name() == "" {
 				log.Printf("Missing file info for line %s and path %s", line, path)
 				return nil
 			}

datasetUtils/getUserInfoFromToken.go

@@ -49,7 +49,7 @@ func GetUserInfoFromToken(client *http.Client, APIServer string, token string) (
 		accessGroups = respObj.CurrentGroups
 		log.Printf("User is member in following groups: %v\n", accessGroups)
 	} else {
-		log.Fatalln("Could not map a user to the token %v", token)
+		log.Fatalf("Could not map a user to the token %v", token)
 	}
 	return u, accessGroups