Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove fs mocked test #1407

Merged
merged 2 commits into from
Jan 23, 2025
Merged

test: remove fs mocked test #1407

merged 2 commits into from
Jan 23, 2025

Conversation

43081j
Copy link
Collaborator

@43081j 43081j commented Jan 23, 2025

Removes the skipped test since we can't really do it in ES modules anyway (as we can't mock ESM exports).

Removes the skipped test since we can't really do it in ES modules
anyway (as we can't mock ESM exports).
@43081j 43081j marked this pull request as ready for review January 23, 2025 09:20
@43081j
Copy link
Collaborator Author

43081j commented Jan 23, 2025

@paulmillr there are a couple of other tests skipped. do you know why?

this one:

describe.skip('Skipping gh-682: should detect unlink', () => {

and this one:

it.skip('should watch paths that were unwatched and added again', async () => {

do you know if/how we can re-enable them?

@paulmillr
Copy link
Owner

they've been failing forever I think. Hard to remember.

@43081j 43081j merged commit 4c3ddd0 into main Jan 23, 2025
22 checks passed
@43081j 43081j deleted the remove-old-test branch January 23, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants