feat: allow specifying initial ice mode #294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC 8445 6.1.1 says: > The initiating agent that started the ICE processing MUST take the controlling role, and the other MUST take the controlled role. The spec also shows how to resolve conflicts when both agents are in the controlling role. From what I can see here, libjuice will always start in controlling mode and try to resolve the conflict before contining but it appears some implementations [don't support that](pion/ice#359 (comment)) so one agent has to start in controlled role. The change here is to allow passing the role to `juice_set_local_ice_attributes` in order to start the receiving agent off in the controlled role.
achingbrain
added a commit
to achingbrain/libdatachannel
that referenced
this pull request
Jan 24, 2025
Exposes the new parameter introduced in paullouisageneau/libjuice#294 Please see that PR for rationale.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 8445 6.1.1 says:
The spec also shows how to resolve conflicts when both agents are in the controlling role.
From what I can see here, libjuice will always start in controlling mode and try to resolve the conflict before contining but it appears some implementations don't support that so one agent has to start in controlled role.
The change here is to allow passing the role to
juice_set_local_ice_attributesin order to start the receiving agent off in the controlled role.