Implement ICE-TCP #293
Draft
Implement ICE-TCP #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paullouisageneau Looking at the different modes conn types (Poll/Thread/Mux) it seems unlikely I would succeed putting the concept of TCP into them. Should I create something multi-threaded that does TCP as its own thread/struct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to take me a while, but I wanted to check in before I started!
I am going to implement both active + passive. My reasoning is I want to be able to test it E2E.
I don't have any hard ideas/opinions on how it should be implemented. Do you have any advice as I learn the code base?