Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump to alpha omega versions #72

Merged
merged 2 commits into from
Jun 3, 2024
Merged

fix: bump to alpha omega versions #72

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14d7b12
fix: bump to alpha omega versions
nicolethoen May 29, 2024
b19b21f
update to official versions
nicolethoen Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions packages/module/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,9 @@
"url": "https://github.com/patternfly/react-user-feedback/issues"
},
"homepage": "https://github.com/patternfly/react-user-feedback#readme",
"resolutions": {
"@patternfly/react-icons": "6.0.0-alpha.19"
},
"dependencies": {
"@patternfly/react-core": "6.0.0-alpha.50",
"@patternfly/react-icons": "6.0.0-alpha.19"
"@patternfly/react-core": "6.0.0-alpha.60",
"@patternfly/react-icons": "6.0.0-alpha.22"
},
"peerDependencies": {
"react": "^17 || ^18",
Expand All @@ -53,10 +50,10 @@
"@types/react": "^18",
"@types/react-dom": "^18",
"@patternfly/patternfly-a11y": "^4.3.1",
"@patternfly/documentation-framework": "6.0.0-alpha.20",
"@patternfly/patternfly":"6.0.0-alpha.117",
"@patternfly/react-table": "6.0.0-alpha.50",
"@patternfly/react-code-editor": "6.0.0-alpha.50",
"@patternfly/documentation-framework": "6.0.0-alpha.35",
"@patternfly/patternfly":"6.0.0-alpha.139",
"@patternfly/react-table": "6.0.0-alpha.60",
"@patternfly/react-code-editor": "6.0.0-alpha.60",
"node-sass-package-importer": "^5.3.2",
"fs-extra": "^9.1.0",
"glob": "^7.2.3",
Expand Down
70 changes: 35 additions & 35 deletions packages/module/patternfly-docs/generated/extensions/user-feedback/design-guidelines.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@ pageData.examples = {

const Component = () => (
<React.Fragment>
<p {...{"className":"ws-p"}}>
<p {...{"className":"undefinedpf-v6-c-content--p ws-p "}}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump the docs framework version to make sure these undefineds go away?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's my plan - that's why I'd tagged you on this PR 👍🏻

{`Note: User feedback lives in its own package at `}
<PatternflyThemeLink {...{"to":"https://github.com/patternfly/react-user-feedback"}}>
{`@patternfly/react-user-feedback`}
</PatternflyThemeLink>
{`.`}
</p>
<p {...{"className":"ws-p"}}>
<p {...{"className":"undefinedpf-v6-c-content--p ws-p "}}>
<strong>
{`User feedback`}
</strong>
Expand All @@ -43,50 +43,50 @@ const Component = () => (
<AutoLinkHeader {...{"id":"elements","size":"h2","className":"ws-title ws-h2"}}>
{`Elements`}
</AutoLinkHeader>
<p {...{"className":"ws-p"}}>
<img src={srcImport0} width={srcImport0.width} height={srcImport0.height} {...{"alt":"Image of advanced feedback modal with annotations","className":"ws-img"}}>
<p {...{"className":"undefinedpf-v6-c-content--p ws-p "}}>
<img src={srcImport0} width={srcImport0.width} height={srcImport0.height} {...{"alt":"Image of advanced feedback modal with annotations","className":"ws-img "}}>
</img>
</p>
<ol {...{"className":"ws-ol"}}>
<li {...{"className":"ws-li"}}>
<ol {...{"className":"undefinedpf-v6-c-content--ol ws-ol "}}>
<li {...{"className":"undefinedpf-v6-c-content--li ws-li "}}>
<strong>
{`Title:`}
</strong>
{` Communicates the title of the modal.`}
</li>
<li {...{"className":"ws-li"}}>
<li {...{"className":"undefinedpf-v6-c-content--li ws-li "}}>
<strong>
{`Description text:`}
</strong>
{` Provides a short description of the form's purpose.`}
</li>
<li {...{"className":"ws-li"}}>
<li {...{"className":"undefinedpf-v6-c-content--li ws-li "}}>
<strong>
{`Image:`}
</strong>
{` Contributes to the modal's visual design.`}
</li>
<li {...{"className":"ws-li"}}>
<li {...{"className":"undefinedpf-v6-c-content--li ws-li "}}>
<strong>
{`Selectable item:`}
</strong>
{` Provides one or more ways that users can leave feedback.`}
</li>
</ol>
<p {...{"className":"ws-p"}}>
<p {...{"className":"undefinedpf-v6-c-content--p ws-p "}}>
{`Each of these elements can be customized to fit a product's needs.`}
</p>
<AutoLinkHeader {...{"id":"behavior","size":"h2","className":"ws-title ws-h2"}}>
{`Behavior`}
</AutoLinkHeader>
<p {...{"className":"ws-p"}}>
<p {...{"className":"undefinedpf-v6-c-content--p ws-p "}}>
{`The user feedback modal may be accessed in your product's help menu.`}
</p>
<p {...{"className":"ws-p"}}>
<p {...{"className":"undefinedpf-v6-c-content--p ws-p "}}>
{`For example, you can allow users to access the modal by selecting a masthead’s help icon and choosing “Share feedback” in the dropdown menu:`}
</p>
<p {...{"className":"ws-p"}}>
<img src={srcImport1} width={srcImport1.width} height={srcImport1.height} {...{"alt":"Image of expanded dropdown menu with link to sharing feedback","className":"ws-img"}}>
<p {...{"className":"undefinedpf-v6-c-content--p ws-p "}}>
<img src={srcImport1} width={srcImport1.width} height={srcImport1.height} {...{"alt":"Image of expanded dropdown menu with link to sharing feedback","className":"ws-img "}}>
</img>
</p>
<AutoLinkHeader {...{"id":"variations","size":"h2","className":"ws-title ws-h2"}}>
Expand All @@ -95,58 +95,58 @@ const Component = () => (
<AutoLinkHeader {...{"id":"modal-items-open-forms-within-the-modal","size":"h3","className":"ws-title ws-h3"}}>
{`Modal items open forms within the modal`}
</AutoLinkHeader>
<p {...{"className":"ws-p"}}>
<p {...{"className":"undefinedpf-v6-c-content--p ws-p "}}>
{`Selecting an item opens a form within the modal, which can submit data over the network.`}
</p>
<p {...{"className":"ws-p"}}>
<p {...{"className":"undefinedpf-v6-c-content--p ws-p "}}>
{`Integrated forms can collect different kinds of feedback:`}
</p>
<ul {...{"className":"ws-ul"}}>
<li {...{"className":"ws-li"}}>
<p {...{"className":"ws-p"}}>
<ul {...{"className":"undefinedpf-v6-c-content--ul ws-ul "}}>
<li {...{"className":"undefinedpf-v6-c-content--li ws-li "}}>
<p {...{"className":"undefinedpf-v6-c-content--p ws-p "}}>
{`General feedback form`}
</p>
<p {...{"className":"ws-p"}}>
<p {...{"className":"undefinedpf-v6-c-content--p ws-p "}}>
{`The general feedback form allows users to enter feedback into a text box and submit.`}
</p>
<p {...{"className":"ws-p"}}>
<img src={srcImport2} width={srcImport2.width} height={srcImport2.height} {...{"alt":"Image of a form within a modal to share feedback","className":"ws-img"}}>
<p {...{"className":"undefinedpf-v6-c-content--p ws-p "}}>
<img src={srcImport2} width={srcImport2.width} height={srcImport2.height} {...{"alt":"Image of a form within a modal to share feedback","className":"ws-img "}}>
</img>
</p>
</li>
<li {...{"className":"ws-li"}}>
<p {...{"className":"ws-p"}}>
<li {...{"className":"undefinedpf-v6-c-content--li ws-li "}}>
<p {...{"className":"undefinedpf-v6-c-content--p ws-p "}}>
{`Bug report form`}
</p>
<p {...{"className":"ws-p"}}>
<p {...{"className":"undefinedpf-v6-c-content--p ws-p "}}>
{`The bug report form allows users to enter feedback into a text box and submit. Its description directs users to a URL where they can submit a support ticket for critical issues.`}
</p>
<p {...{"className":"ws-p"}}>
<img src={srcImport3} width={srcImport3.width} height={srcImport3.height} {...{"alt":"Image of a form within a modal to report bugs","className":"ws-img"}}>
<p {...{"className":"undefinedpf-v6-c-content--p ws-p "}}>
<img src={srcImport3} width={srcImport3.width} height={srcImport3.height} {...{"alt":"Image of a form within a modal to report bugs","className":"ws-img "}}>
</img>
</p>
</li>
<li {...{"className":"ws-li"}}>
<p {...{"className":"ws-p"}}>
<li {...{"className":"undefinedpf-v6-c-content--li ws-li "}}>
<p {...{"className":"undefinedpf-v6-c-content--p ws-p "}}>
{`User research opt-in form`}
</p>
<p {...{"className":"ws-p"}}>
<p {...{"className":"undefinedpf-v6-c-content--p ws-p "}}>
{`The user research opt-in form allows users to enter their email address to participate in future research efforts.`}
</p>
<p {...{"className":"ws-p"}}>
<img src={srcImport4} width={srcImport4.width} height={srcImport4.height} {...{"alt":"Image of a form within a modal to sign up for research opportunities","className":"ws-img"}}>
<p {...{"className":"undefinedpf-v6-c-content--p ws-p "}}>
<img src={srcImport4} width={srcImport4.width} height={srcImport4.height} {...{"alt":"Image of a form within a modal to sign up for research opportunities","className":"ws-img "}}>
</img>
</p>
</li>
</ul>
<AutoLinkHeader {...{"id":"modal-items-link-to-external-urls","size":"h3","className":"ws-title ws-h3"}}>
{`Modal items link to external URLs`}
</AutoLinkHeader>
<p {...{"className":"ws-p"}}>
<p {...{"className":"undefinedpf-v6-c-content--p ws-p "}}>
{`Selecting an item redirects users to an external URL (like a qualtrics form) that opens in a separate tab.`}
</p>
<p {...{"className":"ws-p"}}>
<img src={srcImport5} width={srcImport5.width} height={srcImport5.height} {...{"alt":"Image of modal with links to external forms","className":"ws-img"}}>
<p {...{"className":"undefinedpf-v6-c-content--p ws-p "}}>
<img src={srcImport5} width={srcImport5.width} height={srcImport5.height} {...{"alt":"Image of modal with links to external forms","className":"ws-img "}}>
</img>
</p>
</React.Fragment>
Expand Down
Loading
Loading