fix(ContextSubMenuItem): fix popper container #271
+19
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcfaul
reviewed
Feb 4, 2025
| > | ||
| <Dropdown toggle={() => <></>} className={css(topologyStyles.topologyContextMenuCDropdownMenu)}> |
There was a problem hiding this comment.
Is this class still needed?
There was a problem hiding this comment.
It's also used here:
| @@ -11,6 +11,11 @@ interface ContextSubMenuItemProps { | |||
| children: React.ReactNode[]; | |||
| } | |||
|
|
|||
| /** Check if an event target is also a node. Needed to stop runtime errors where the target does not implement Node. */ | |||
| const isNode = (node: any): boolean => { | |||
There was a problem hiding this comment.
Can we rename this to isHTMLNode or something not to be confused with a Topology Node?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #270
Description
The root issue ended up being that
Dropdownalso implements aPopper, so although the topology portal goes to the correct element in the DOM, the portal inside the Dropdown goes todocument.body. Since the Dropdown is a child of the topology popper, it takes precedence, causing the children to go to the body instead of its intended locationType of change
Screen shots / Gifs for design review
Screencast.From.2025-02-04.10-42-29.mp4