Merge pull request #78 from nicolethoen/fix_href_onclick

fix: address regression when onclick and href provided
patternfly · Jan 17, 2025 · e8eb0e1 · e8eb0e1
2 parents 7738f40 + bb176fe
commit e8eb0e1
Showing 1 changed file with 14 additions and 4 deletions.
diff --git a/packages/module/src/components/CatalogTile/CatalogTile.tsx b/packages/module/src/components/CatalogTile/CatalogTile.tsx
@@ -63,14 +63,24 @@ export class CatalogTile extends React.Component<CatalogTileProps> {
   private handleClick = (e: React.FormEvent<HTMLInputElement> | React.MouseEvent<Element, MouseEvent>) => {
     const { onClick, href } = this.props;
 
-    if (!href) {
-      e.preventDefault();
-    } else {
+    if ("type" in e && e.type === "click" && onClick) {
+      // It's a MouseEvent
+      const mouseEvent = e as React.MouseEvent<Element, MouseEvent>;
+      if (
+        mouseEvent.metaKey || // Cmd key (Mac)
+        mouseEvent.ctrlKey || // Ctrl key
+        mouseEvent.shiftKey // Shift key
+      ) {
+        window.open(href, '_blank');
+        return; 
+      }
+    } else if (href){
       window.open(href, '_blank');
     }
+
     if (onClick) {
       onClick(e);
-    }
+    } 
   };
 
   private renderBadges = (badges: React.ReactNode[]) => {