Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix react-table not expose index.d.ts issue #1281

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Fix react-table not expose index.d.ts issue #1281

merged 1 commit into from
Feb 1, 2019

Conversation

kunyan
Copy link
Contributor

@kunyan kunyan commented Jan 30, 2019

What: Add index.d.ts for react-table

Additional issues:

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://1281-pr-patternfly-react-patternfly.surge.sh

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4210

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.154%
Totals Coverage Status
Change from base Build 4199: 0.0%
Covered Lines: 4622
Relevant Lines: 5414
💛 - Coveralls

@karelhala karelhala self-requested a review January 30, 2019 08:56
tlabaj
tlabaj approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlabaj dlabaj merged commit aab28b9 into patternfly:master Feb 1, 2019
@kunyan kunyan deleted the fix-react-table-types branch February 1, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karelhala karelhala karelhala approved these changes

@dlabaj dlabaj dlabaj approved these changes

@tlabaj tlabaj tlabaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kunyan @patternfly-build @coveralls @karelhala @dlabaj @tlabaj