-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some post-PF5 fixes: Make cards clickable, fix card styling, open links in new tab #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jschuler
commented
Mar 7, 2024
- Make cards clickable
- Fix card active/hover styling
- Open links in new tab
✅ Deploy Preview for quickstarts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dlabaj
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it and it works. LGTM
dlabaj
approved these changes
Mar 7, 2024
🎉 This PR is included in version 5.4.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
dlabaj
pushed a commit
to dlabaj/patternfly-quickstarts
that referenced
this pull request
Jun 27, 2024
…ks in new tab (patternfly#289) * fix(quickstart tile): opening quickstarts on click event * some other fixes * better bookmarking example * small css fix --------- Co-authored-by: Martin Marosi <[email protected]>
dlabaj
pushed a commit
to dlabaj/patternfly-quickstarts
that referenced
this pull request
Jul 1, 2024
…ks in new tab (patternfly#289) * fix(quickstart tile): opening quickstarts on click event * some other fixes * better bookmarking example * small css fix --------- Co-authored-by: Martin Marosi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.