Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(quickstart tile): opening quickstarts on click event #288

Merged

Conversation

Hyperkid123
Copy link
Contributor

@Hyperkid123 Hyperkid123 commented Feb 29, 2024

The quickstarts panel is not opening on tile click. Only on the Enter key press. Currently, the click is sending different arguments in the event handler.

Also the CatalogTile is for some reason blocking the click handler. I've moved it to the parent div so it is triggering again.

@Hyperkid123 Hyperkid123 force-pushed the send-correct-quickstarts-argument branch from ca13988 to bd4da50 Compare February 29, 2024 10:08
Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for quickstarts ready!

Name Link
🔨 Latest commit 8779ab3
🔍 Latest deploy log https://app.netlify.com/sites/quickstarts/deploys/65e05dfb8c54450008a42b98
😎 Deploy Preview https://deploy-preview-288--quickstarts.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Hyperkid123 Hyperkid123 changed the title fix(quickstart tile): send correct id to setActiveQuickstart on click fix(quickstart tile): opening quickstarts on click event Feb 29, 2024
@Hyperkid123 Hyperkid123 force-pushed the send-correct-quickstarts-argument branch from bd4da50 to 8779ab3 Compare February 29, 2024 10:13
@dlabaj dlabaj merged commit f1a59fb into patternfly:main Mar 7, 2024
11 of 13 checks passed
Copy link

github-actions bot commented Mar 7, 2024

🎉 This PR is included in version 5.2.0-prerelease.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Hyperkid123 Hyperkid123 deleted the send-correct-quickstarts-argument branch March 8, 2024 08:58
dlabaj pushed a commit to dlabaj/patternfly-quickstarts that referenced this pull request Jun 27, 2024
dlabaj pushed a commit to dlabaj/patternfly-quickstarts that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants