feat(Compare): Add compare layout #399
Open
+435
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://chatbot-pr-chatbot-399.surge.sh A11y report: https://chatbot-pr-chatbot-399-a11y.surge.sh |
rebeccaalpert
force-pushed
the
compare
branch
3 times, most recently
from
01759af to
f3425a7
Compare
edonehoo
requested changes
Jan 9, 2025
packages/module/patternfly-docs/content/extensions/chatbot/examples/demos/Chatbot.md
Outdated
Show resolved
Hide resolved
...dule/patternfly-docs/content/extensions/chatbot/examples/demos/EmbeddedComparisonChatbot.tsx
Outdated
Show resolved
Hide resolved
...dule/patternfly-docs/content/extensions/chatbot/examples/demos/EmbeddedComparisonChatbot.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Erin Donehoo <[email protected]>
edonehoo
approved these changes
Jan 9, 2025
packages/module/patternfly-docs/content/extensions/chatbot/examples/demos/Chatbot.md
Show resolved
Hide resolved
nicolethoen
reviewed
Jan 10, 2025
|
|
||
| return ( | ||
| <Page masthead={masthead} sidebar={sidebar} isContentFilled> | ||
| <div className="pf-chatbot__compare-container"> |
There was a problem hiding this comment.
so these classnames are being used in the demo as necessary to create the layout and apply styles. I think they are going to need to be included/called out in the demo docs somehow. Could you maybe add a nolive code block in the content above the example to outline the structure and classes needed? Something like an outline... like:
<Page or PageSection>
<div className="pf-chatbot__compare-container">
<div className="pf-chatbot__compare-mobile-controls">
...
</div>
</div>
</Page or PageSection>
45d741e to
f4eb2ae
Compare
rebeccaalpert
force-pushed
the
compare
branch
from
f4eb2ae to
1eaac2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo is here for now: https://chatbot-pr-chatbot-399.surge.sh/patternfly-ai/chatbot/overview/demo/comparing-chatbots/
I stuck it under Overview/Demos for now (https://chatbot-pr-chatbot-399.surge.sh/patternfly-ai/chatbot/overview/demo#comparison), but totally happy to move it elsewhere. All I'm shipping as part of the extension for this is a handful of CSS classes.
Will generate screenshots once we decide on docs placement.