Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/sc 133701/tachyon setup is rehashing an already hashed #793

Merged

Conversation

hugomontero
Copy link
Contributor

@hugomontero hugomontero commented Feb 11, 2025

Description

  • Fix the way setup handle passwords that comes from a config file.
  • Fix wifi password setting given that currently is returning undefined instead the actual data.

How to Test

  1. Pull down the branch: git pull && git checkout bug/sc-133701/tachyon-setup-is-rehashing-an-already-hashed
  2. Attempt to setup a tachyon and save the config: npm start -- tachyon setup --save_config my_config.cfg
  3. Attempt to setup again the tachyon but using the previously saved config (save it again): npm start -- tachyon setup --load_config my_config.cfg --save_config my_new_config.cfg

outcome

  • wifi password should be stored in the config
  • on the second attempt the system password should be match with the first file.

Related Issues / Discussions

Story details: https://app.shortcut.com/particle/story/133701

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA
  • Problem and solution clearly stated
  • Tests have been provided
  • Docs have been updated
  • CI is passing

@hugomontero hugomontero requested review from keeramis, avtolstoy and azenk and removed request for avtolstoy February 11, 2025 15:53
Copy link

@azenk azenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@hugomontero hugomontero merged commit 93b4bab into master Feb 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants