-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/#66 스케줄러 모듈 분리 #68
Merged
The head ref may contain hidden characters: "Refactor/#66_\uC2A4\uCF00\uC904\uB7EC_\uBAA8\uB4C8_\uBD84\uB9AC"
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
6383e7a
refactor: 루트 설정 변경
This2sho 72ff933
refactor: 도메인 모듈 분리
This2sho f471dfd
refactor: api 모듈 분리
This2sho 68682b7
refactor: scheduler 모듈 분리
This2sho 65dbd3f
refactor: 기존 소스코드 삭제
This2sho a4700d0
refactor: 루트 gradle 설정
This2sho 281f207
refactor: CI 멀티 모듈로 인한 변경 사항 적용
This2sho 11dee57
refactor: CD 멀티 모듈로 인한 변경 사항 적용
This2sho b9929d2
fix: 깃헙 액션에서 이전 커밋도 가져오도록 수정
This2sho 086b975
feat: gradle 테스트 결과 모아주는 task 추가
This2sho 336a4b2
refactor: domain 변경시 gradle 병렬로 수행하도록 수정
This2sho b98101c
fix: 깃헙 액션 계속 도는 문제 해결
This2sho 1501092
fix: 값 바껴있는거 수정
This2sho 4bbad4d
refactor: Exception 모듈에 맞게 의존성 분리
This2sho 0aeac73
fix: CI 다시 돌게 수정
This2sho 01cc85b
refactor: exception support 패키지로 이동
This2sho cc86092
refactor: TestConfig, ContainerTest 상위 패키지로 이동
This2sho 03d259d
refactor: 도메인 프로젝트 명 common으로 변경
This2sho 4a2d3da
refactor: CD 스크립트 수정
This2sho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
.gradle | ||
build/ | ||
!gradle/wrapper/gradle-wrapper.jar | ||
!**/src/main/**/build/ | ||
!**/src/test/**/build/ | ||
|
||
### IntelliJ IDEA ### | ||
.idea/modules.xml | ||
.idea/jarRepositories.xml | ||
.idea/compiler.xml | ||
.idea/libraries/ | ||
*.iws | ||
*.iml | ||
*.ipr | ||
out/ | ||
!**/src/main/**/out/ | ||
!**/src/test/**/out/ | ||
|
||
### Eclipse ### | ||
.apt_generated | ||
.classpath | ||
.factorypath | ||
.project | ||
.settings | ||
.springBeans | ||
.sts4-cache | ||
bin/ | ||
!**/src/main/**/bin/ | ||
!**/src/test/**/bin/ | ||
|
||
### NetBeans ### | ||
/nbproject/private/ | ||
/nbbuild/ | ||
/dist/ | ||
/nbdist/ | ||
/.nb-gradle/ | ||
|
||
### VS Code ### | ||
.vscode/ | ||
|
||
### Mac OS ### | ||
.DS_Store |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
FROM amazoncorretto:17-alpine | ||
|
||
COPY build/libs/parking-0.0.1-SNAPSHOT.jar app.jar | ||
COPY build/libs/app-api-0.0.1-SNAPSHOT.jar app.jar | ||
|
||
CMD ["java", "-jar", "app.jar"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
dependencies { | ||
implementation project(':domain') | ||
|
||
testImplementation platform('org.junit:junit-bom:5.9.1') | ||
testImplementation 'org.junit.jupiter:junit-jupiter' | ||
|
||
implementation 'org.springdoc:springdoc-openapi-starter-webmvc-ui:2.0.2' | ||
implementation group: 'org.hibernate.orm', name: 'hibernate-spatial', version: '6.3.1.Final' | ||
|
||
// 메일 | ||
implementation 'org.springframework.boot:spring-boot-starter-mail' | ||
|
||
// redis | ||
implementation 'org.springframework.boot:spring-boot-starter-data-redis' | ||
|
||
// testcontainer | ||
testImplementation "org.testcontainers:testcontainers:1.19.6" | ||
testImplementation "org.testcontainers:junit-jupiter:1.19.6" | ||
testImplementation "com.redis:testcontainers-redis:2.2.0" | ||
testImplementation "org.testcontainers:mysql:1.19.6" | ||
|
||
testImplementation(testFixtures(project(":domain"))) | ||
} |
8 changes: 3 additions & 5 deletions
8
...m/example/parking/ParkingApplication.java → .../com/parkingcomestrue/ApiApplication.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,21 @@ | ||
package com.example.parking; | ||
package com.parkingcomestrue; | ||
|
||
import jakarta.annotation.PostConstruct; | ||
import java.util.TimeZone; | ||
import org.springframework.boot.SpringApplication; | ||
import org.springframework.boot.autoconfigure.SpringBootApplication; | ||
import org.springframework.data.jpa.repository.config.EnableJpaAuditing; | ||
import org.springframework.scheduling.annotation.EnableScheduling; | ||
|
||
@EnableJpaAuditing | ||
@EnableScheduling | ||
@SpringBootApplication | ||
public class ParkingApplication { | ||
public class ApiApplication { | ||
|
||
@PostConstruct | ||
public void started() { | ||
TimeZone.setDefault(TimeZone.getTimeZone("Asia/Seoul")); | ||
} | ||
|
||
public static void main(String[] args) { | ||
SpringApplication.run(ParkingApplication.class, args); | ||
SpringApplication.run(ApiApplication.class, args); | ||
} | ||
} |
10 changes: 5 additions & 5 deletions
10
...auth/authcode/api/AuthCodeController.java → ...api/auth/authcode/AuthCodeController.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 5 additions & 5 deletions
10
...king/api/favorite/FavoriteController.java → ...king/api/favorite/FavoriteController.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 8 additions & 8 deletions
16
.../parking/api/member/MemberController.java → .../parking/api/member/MemberController.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 9 additions & 9 deletions
18
...arking/api/parking/ParkingController.java → ...arking/api/parking/ParkingController.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
.../parking/api/review/ReviewController.java → .../parking/api/review/ReviewController.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
...hcondition/SearchConditionController.java → ...hcondition/SearchConditionController.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if 분기를 하니 ci flow 가 복잡한 느낌이 조금 드네요.
모듈 별로 ci 파일을 분기하는건 어떠신가요?
branches 트리거 부분을 paths 로 대체하여 "domain/**" 이런식으로 작성하면 해당 모듈에 변경이 발생하면 ci 가 동작하더라구요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
트리거 부분 예시입니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 처음에
path
로 트리거를 하고 모듈 별로 ci를 따로 하려고 했는데그러면 다음과 같은 문제가 생깁니다.
step
이 동일한데, 중복이 발생한다.